posthog migration: part 3 #7365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis change removes all analytics tracking infrastructure and logic from the dashboard application. All tracking-related props, components (such as TrackedLink, TrackedLinkTW, TrackedUnderlineLink, TrackedCopyButton), and the useTrack hook are deleted. All UI components and links now use standard, non-tracking equivalents, and all tracking metadata is eliminated from props and types. Additionally, the Changes
Sequence Diagram(s)Not generated, as the changes are broad refactors removing tracking logic rather than introducing or modifying specific control flows. Possibly related PRs
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7365 +/- ##
=======================================
Coverage 52.35% 52.35%
=======================================
Files 939 939
Lines 63161 63161
Branches 4217 4217
=======================================
Hits 33070 33070
Misses 29984 29984
Partials 107 107
🚀 New features to boost your workflow:
|
jnsdls
force-pushed
the
06-17-posthog_migration_part_3
branch
from
d3a5396 to
f0bb043
Compare
jnsdls
force-pushed
the
06-17-posthog_migration_part_2
branch
from
604a6e9 to
6754c8b
Compare
jnsdls
force-pushed
the
06-17-posthog_migration_part_3
branch
from
f0bb043 to
50192f2
Compare
jnsdls
force-pushed
the
06-17-posthog_migration_part_2
branch
from
6754c8b to
5924b03
Compare
jnsdls
force-pushed
the
06-17-posthog_migration_part_2
branch
from
e85d198 to
738e9bb
Compare
jnsdls
force-pushed
the
06-17-posthog_migration_part_3
branch
from
b1e03cb to
0a882e9
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: LinkedIn Link Typo and Security Issue
The LinkedIn social media link in the footer has a pre-existing typo in its href attribute (hhttps://www.linkedin.com/company/third-web/), causing a broken link. It also lacks the rel="noopener noreferrer" security attribute, unlike other social media links in the footer that were updated in this commit to include it.
apps/dashboard/src/@/components/blocks/app-footer.tsx#L99-L106
js/apps/dashboard/src/@/components/blocks/app-footer.tsx
Lines 99 to 106 in 0a882e9
Was this report helpful? Give feedback by reacting with 👍 or 👎
Merge activity
|
# Remove Analytics Tracking Components
This PR removes analytics tracking components and properties from the dashboard app. Key changes include:
- Removed `TrackedLinkTW` and `TrackedUnderlineLink` components, replacing them with standard `Link` and `UnderlineLink` components
- Removed tracking properties from sidebar links and navigation components
- Eliminated tracking metadata from contract cards, NFT cards, and marketplace components
- Removed tracking-related props from various UI components
- Simplified component interfaces by removing tracking-specific parameters
- Replaced legacy tracked button components with standard button components
These changes simplify the codebase by removing the analytics tracking layer while maintaining all core functionality.
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing security by adding `rel="noopener noreferrer"` to various `Link` components throughout the codebase to prevent potential security vulnerabilities associated with opening links in new tabs.
### Detailed summary
- Added `rel="noopener noreferrer"` to multiple `Link` components for security.
- Removed `tracking` properties from several components.
- Replaced `TrackedLinkTW` with `Link` or `UnderlineLink` in various files.
- Updated imports to use `Link` from `next/link` instead of custom tracking links.
> The following files were skipped due to too many changes: `apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/engine/dedicated/(instance)/[engineId]/metrics/components/EngineSystemMetrics.tsx`, `apps/dashboard/src/tw-components/link.tsx`, `apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/_components/NFTCards.tsx`, `apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/engine/dedicated/(general)/import/EngineImportPage.tsx`, `apps/dashboard/src/components/explore/upsells/deploy-your-own.tsx`, `apps/dashboard/src/components/contract-functions/interactive-abi-function.tsx`, `apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/overview/components/LatestEvents.tsx`, `apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/engine/dedicated/(instance)/[engineId]/contract-subscriptions/components/engine-contract-subscription.tsx`, `apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/engine/dedicated/(general)/_components.tsx`, `apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/engine/dedicated/(instance)/[engineId]/_components/version.tsx`, `apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/overview/components/NFTDetails.tsx`, `apps/dashboard/src/@3rdweb-sdk/react/components/connect-wallet/index.tsx`, `apps/dashboard/src/components/contract-components/publisher/publisher-header.tsx`, `apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/overview/ContractOverviewPage.tsx`, `apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/overview/components/PermissionsTable.tsx`, `apps/dashboard/src/app/(app)/(dashboard)/profile/[addressOrEns]/components/PublishedContractTable.tsx`, `apps/dashboard/src/components/explore/contract-card/index.tsx`, `apps/dashboard/src/contract-ui/tabs/code/components/code-overview.tsx`, `apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/connect/account-abstraction/factories/page.tsx`, `apps/dashboard/src/components/embedded-wallets/Configure/index.tsx`, `apps/dashboard/src/@/components/blocks/app-footer.tsx`, `apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/components/footer/FooterLinksSection.tsx`, `apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/connect/account-abstraction/AccountAbstractionPage.tsx`, `apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/components/ProjectSidebarLayout.tsx`, `apps/dashboard/src/components/buttons/MismatchButton.tsx`, `apps/dashboard/src/tw-components/button.tsx`, `apps/dashboard/src/components/smart-wallets/SponsorshipPolicies/index.tsx`, `apps/dashboard/src/components/cmd-k-search/index.tsx`, `apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/components/ProjectFTUX/ProjectFTUX.tsx`, `apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/overview/components/MarketplaceDetails.tsx`
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
- **Refactor**
- Removed all analytics tracking from links and buttons across the dashboard.
- Replaced custom tracking link and button components with standard or simplified alternatives.
- Updated component props and interfaces to eliminate tracking-related fields.
- Streamlined UI components by removing tracking props and logic, resulting in cleaner navigation and interactions.
- **Style**
- Added `rel="noopener noreferrer"` attribute to all external links opening in new tabs for improved security and privacy.
- Minor adjustments to link styling in some components to accommodate new link components.
No changes to core functionality or user workflows; navigation and UI remain consistent.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
graphite-app
bot
force-pushed
the
06-17-posthog_migration_part_2
branch
from
738e9bb to
5f2bca8
Compare
graphite-app
bot
force-pushed
the
06-17-posthog_migration_part_3
branch
from
0a882e9 to
d9eee50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Analytics Tracking Components
This PR removes analytics tracking components and properties from the dashboard app. Key changes include:
TrackedLinkTWandTrackedUnderlineLinkcomponents, replacing them with standardLinkandUnderlineLinkcomponentsThese changes simplify the codebase by removing the analytics tracking layer while maintaining all core functionality.
PR-Codex overview
This PR focuses on enhancing link security by adding
rel="noopener noreferrer"to various<Link>components throughout the application, which helps prevent potential security risks when opening links in new tabs.Detailed summary
rel="noopener noreferrer"to multiple<Link>components.TrackedLinkTWcomponent in favor of standard<Link>for consistency.Summary by CodeRabbit
Refactor
Style
rel="noopener noreferrer"attribute to all external links opening in new tabs for improved security and privacy.No changes to core functionality or user workflows; navigation and UI remain consistent.